openinx commented on a change in pull request #2294:
URL: https://github.com/apache/iceberg/pull/2294#discussion_r596622281
##########
File path: api/src/main/java/org/apache/iceberg/RewriteFiles.java
##########
@@ -35,11 +36,30 @@
*/
public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
/**
- * Add a rewrite that replaces one set of files with another set that
contains the same data.
+ * Add a rewrite that replaces one set of data files with another set that
contains the same data.
*
* @param filesToDelete files that will be replaced (deleted), cannot be
null or empty.
- * @param filesToAdd files that will be added, cannot be null or empty.
+ * @param filesToAdd files that will be added, cannot be null or empty.
* @return this for method chaining
*/
- RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile>
filesToAdd);
+ default RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile>
filesToAdd) {
+ return rewriteFiles(
+ filesToDelete,
+ ImmutableSet.of(),
+ filesToAdd,
+ ImmutableSet.of()
+ );
+ }
+
+ /**
+ * Add a rewrite that replaces one set of files with another set that
contains the same data (format v2).
Review comment:
Agreed !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
