Sealina commented on issue #2347:
URL: https://github.com/apache/iceberg/issues/2347#issuecomment-804221597
Thank you. On top of that, I also detected that this statement will fail:
```
assertEquals(
Types.NestedField.required(1, "FieldName", new Types.IntegerType()),
Types.NestedField.required(1, "FieldName", new Types.IntegerType())
)
```
because NestedField equality relies on equality of type object (not typeId):
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/types/Types.java#L520
Given that in a unit test, we may not have explicit control over what actual
NestedField object we get when we do assertEquals, is there a better way we can
validate the NestedField object we get is as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
