rdblue commented on pull request #2328: URL: https://github.com/apache/iceberg/pull/2328#issuecomment-804448385
@RussellSpitzer, @aokolnychyi, I think the approach here is good. I like that existing behavior is kept but the new exception provides a way to change it. I don't think that we need the ability to mark a commit idempotent yet since this is an alternative way to avoid deleting the files. Once the comments above are addressed, I think this can be committed to master. I know the intent is to get this into a patch release, but I don't think that we should do that with a new behavior change for Hive catalogs by default. The problem used to cause tables to be unwritable (in most cases) until rolled back. But this changes the behavior and makes the table still writable. That's the right direction, but I don't think the change should be in a patch release. We could, however, add this with a flag to still delete the data files or to fall back to not throwing the unknown commit state exception. I'd be comfortable with that going in a patch release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
