rdblue commented on a change in pull request #2293:
URL: https://github.com/apache/iceberg/pull/2293#discussion_r600003774
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -84,10 +84,14 @@
private boolean hasNewDeleteFiles = false;
MergingSnapshotProducer(String tableName, TableOperations ops) {
+ this(tableName, ops, ops.current().spec());
+ }
+
+ MergingSnapshotProducer(String tableName, TableOperations ops, PartitionSpec
spec) {
Review comment:
I don't think that `spec` should be passed in the constructor. See my
comments on `BaseRewriteFiles`.
Instead, I think we should initially set the spec ID to null and initialize
it the first time a `DataFile` is added. Then validate that all other data
files use the same ID. That way we don't need a new API method and maintain
flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
