aokolnychyi commented on a change in pull request #2361:
URL: https://github.com/apache/iceberg/pull/2361#discussion_r600224995
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/RewriteManifestsActionResult.java
##########
@@ -23,6 +23,7 @@
import org.apache.iceberg.ManifestFile;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+@Deprecated
Review comment:
These are really tightly coupled with the action. I don't see how one
could use new action with the old API or just the action result alone. As I am
lazy and I was not sure how useful that's going to be, I did not add it.
What do you think, @RussellSpitzer?
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseExpireSnapshotsSparkAction.java
##########
@@ -29,7 +29,6 @@
import org.apache.iceberg.TableMetadata;
import org.apache.iceberg.TableOperations;
import org.apache.iceberg.actions.BaseExpireSnapshotsActionResult;
-import org.apache.iceberg.actions.BaseSparkAction;
Review comment:
Fixed.
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseRemoveOrphanFilesSparkAction.java
##########
@@ -34,7 +34,6 @@
import org.apache.iceberg.Table;
import org.apache.iceberg.TableOperations;
import org.apache.iceberg.actions.BaseRemoveOrphanFilesActionResult;
-import org.apache.iceberg.actions.BaseSparkAction;
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
