aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r600970830



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java
##########
@@ -38,6 +39,13 @@
   private SparkUtil() {
   }
 
+  public static Table toStaticTable(Table table) {
+    // TODO: consider setting some fields as null to reduce the size

Review comment:
       It works but Spark uses Java serialization for Hadoop configs.
   
   ```
   kryo.register(classOf[SerializableConfiguration], new KryoJavaSerializer())
   ```
   
   By reusing `SerializableConfiguration` from Spark, we don't have to register 
our own custom Kryo serializer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to