rdblue commented on pull request #2330: URL: https://github.com/apache/iceberg/pull/2330#issuecomment-807231637
@aokolnychyi, I think we can add more reserved properties in parallel. It's a good idea to add sort order, but spec can already be viewed in Spark using `DESCRIBE FORMATTED` so I don't think we need to add it. We should also consider the fact that users will try to set these properties directly, and make sure we have a good error message when it doesn't work. This PR looks good to me. Any other comments before merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
