openinx opened a new pull request #2386: URL: https://github.com/apache/iceberg/pull/2386
Currently, the FlinkTestBase#sql will returns a `List<Object[]>`, which is not friendly to assert the results of flink SQL query because for a record, we have to build a `Object` array , and then use the `Assert.assertArrayEquals((Object[])result, expected)` to check the equality. It's hard to assert the record that read from a table with nested column. So I recommend to return a `List<Row>` for the `FlinkTestBase#sql` because the flink's row have considered the equal logic for nested columns, pls see the [equals](https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/types/Row.java#L405) method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
