uncleGen commented on a change in pull request #2380:
URL: https://github.com/apache/iceberg/pull/2380#discussion_r601028952
##########
File path:
spark3/src/main/java/org/apache/iceberg/actions/Spark3SnapshotAction.java
##########
@@ -135,10 +140,23 @@ protected TableCatalog checkSourceCatalog(CatalogPlugin
catalog) {
@Override
public SnapshotAction withLocation(String location) {
- Preconditions.checkArgument(!sourceTableLocation().equals(location),
Review comment:
`sourceTableLocation` is converted from URI, while `location` comes from
SQL command. We should qualify the `location` before check equals. A fault
example:
- sourceTableLocation: hdfs://a.b.c.d:9000/source/location
- location: /source/location
If we compare them with previous logic, it was `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
