rdblue commented on a change in pull request #2284:
URL: https://github.com/apache/iceberg/pull/2284#discussion_r603677197
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -842,18 +844,42 @@ private static SortOrder updateSortOrderSchema(Schema
schema, SortOrder sortOrde
return builder.build();
}
- private static PartitionSpec freshSpec(int specId, Schema schema,
PartitionSpec partitionSpec) {
+ private static PartitionSpec freshSpec(int specId, Schema schema,
PartitionSpec partitionSpec, int formatVersion,
+ List<PartitionSpec> specs,
AtomicInteger lastPartitionId) {
Review comment:
I noted above that I don't think that we should change the behavior of
`freshSpec` for `updatePartitionSpec`. Instead, what about creating a
`reassignPartitionIds` method that gets called after `freshSpec` in
`buildReplacement`? That would be similar to how schemas are handled, where the
existing schema is passed to seed the IDs for the new table schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
