aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r603772820
##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -59,6 +60,11 @@ public OutputFileFactory(PartitionSpec spec, FileFormat
format, LocationProvider
this(spec, format, locations, io, encryptionManager, partitionId, taskId,
UUID.randomUUID().toString());
}
+ public OutputFileFactory(Table table, FileFormat format, int partitionId,
long taskId) {
Review comment:
This particular call also passes partition id. I think
`OutputFileFactory` should have a builder. I added a TODO item and would
propose to refactor this part once we switch to the builder approach. How does
that sound, @pvary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
