aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r603784062
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -60,6 +61,11 @@
private StructType eqDeleteSparkType = null;
private StructType posDeleteSparkType = null;
+ // TODO: expose a builder like SparkAppenderFactory.forTable()
Review comment:
@szehon-ho, I think you had a builder in your PR. Would you be
interested to submit separate PR for that once this one is in?
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -60,6 +61,11 @@
private StructType eqDeleteSparkType = null;
private StructType posDeleteSparkType = null;
+ // TODO: expose a builder like SparkAppenderFactory.forTable()
Review comment:
@szehon-ho, I think you had a builder in your PR. Would you be
interested to submit a separate PR for that once this one is in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
