rdblue commented on a change in pull request #2392:
URL: https://github.com/apache/iceberg/pull/2392#discussion_r604332662
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -120,10 +120,13 @@ public Catalog createCatalog(String name, Map<String,
String> properties) {
protected Catalog createCatalog(String name, Map<String, String> properties,
Configuration hadoopConf) {
CatalogLoader catalogLoader = createCatalogLoader(name, properties,
hadoopConf);
String defaultDatabase = properties.getOrDefault(DEFAULT_DATABASE,
"default");
- String[] baseNamespace = properties.containsKey(BASE_NAMESPACE) ?
-
Splitter.on('.').splitToList(properties.get(BASE_NAMESPACE)).toArray(new
String[0]) :
- new String[0];
boolean cacheEnabled =
Boolean.parseBoolean(properties.getOrDefault(CACHE_ENABLED, "true"));
+
+ Namespace baseNamespace = Namespace.empty();
+ if (properties.containsKey(BASE_NAMESPACE)) {
+ baseNamespace =
Namespace.of(properties.get(BASE_NAMESPACE).split("\\."));
+ }
Review comment:
Why move this below `cacheEnabled`? That seems like it would cause
unnecessary git conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
