aokolnychyi commented on pull request #2343: URL: https://github.com/apache/iceberg/pull/2343#issuecomment-810685833
I am afraid it does not solve our issues with Kryo. We still are going to fail if we get a non-serializable byte buffer. I think `SerializableByteBufferMap` fixes the problem for Java serialization but we don't really have a solution for Kryo. If we switch to `DirectByteBuffer` from `HeapByteBuffer`, the Kryo tests in this PR will fail. We probably have two options: - Require a custom serializer to be registered for non-serializable byte buffer implementations. - Modify `SerializableByteBufferMap` to store array bytes, which would mean eager conversion of byte buffers to arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
