yyanyy commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r604543881
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -127,10 +127,16 @@ static TableMetadata newTableMetadata(Schema schema,
public static class SnapshotLogEntry implements HistoryEntry {
private final long timestampMillis;
private final long snapshotId;
+ private final Integer schemaId;
- SnapshotLogEntry(long timestampMillis, long snapshotId) {
+ SnapshotLogEntry(long timestampMillis, long snapshotId, Integer schemaId) {
Review comment:
Thank you for the review! I think I originally added it to history so
that we can directly query history entries to get both snapshot ID and schema
ID when we do time based time travel queries, but later I didn't end up using
it for the utility methods I [used to
have](https://github.com/apache/iceberg/pull/2275/commits/bc534a8f9551c4fb12226c2121001b7cf98f2bb1)
so I think we can drop it. I'll update the PR to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
