aokolnychyi commented on a change in pull request #2398:
URL: https://github.com/apache/iceberg/pull/2398#discussion_r605309634



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -195,12 +218,9 @@ public String toString() {
     return name();
   }
 
-  abstract String metadataLocation();

Review comment:
       I don't think `BaseMetadataTable` is public and this method was added 
for serialization. I am going to rework table serialization in the next PR and 
we won't depend on this method.
   
   That said, I don't mind keeping this too if there is a good use case. I just 
thought it is a pretty internal API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to