RussellSpitzer commented on a change in pull request #2403:
URL: https://github.com/apache/iceberg/pull/2403#discussion_r605809313
##########
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##########
@@ -679,6 +680,10 @@ public LocationProvider locationProvider() {
public String toString() {
return name();
}
+
+ Object writeReplace() {
Review comment:
```Serializable classes that need to designate an alternative object to
be used when writing an object to the stream should implement this special
method with the exact signature:
ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException;
This writeReplace method is invoked by serialization if the method exists
and it would be accessible from a method defined within the class of the object
being serialized. Thus, the method can have private, protected and
package-private access. Subclass access to this method follows java
accessibility rules.
Classes that need to designate a replacement when an instance of it is read
from the stream should implement this special method with the exact signature.
ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException;```
? Should we throw objectStream Exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
