jackye1995 commented on a change in pull request #2402:
URL: https://github.com/apache/iceberg/pull/2402#discussion_r605917390
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
##########
@@ -113,29 +112,28 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
checkMetadataLocation(glueTable, base);
Map<String, String> properties = prepareProperties(glueTable,
newMetadataLocation);
- try {
- persistGlueTable(glueTable, properties);
- commitStatus = CommitStatus.SUCCESS;
- } catch (Throwable persistFailure) {
- LOG.error("Confirming if commit to {} indeed failed to persist,
attempting to reconnect and check.",
- fullTableName, persistFailure);
- commitStatus = checkCommitStatus(newMetadataLocation, metadata);
- switch (commitStatus) {
- case SUCCESS:
- break;
- case FAILURE:
- throw persistFailure;
- case UNKNOWN:
- throw new CommitStateUnknownException(persistFailure);
- }
- }
+ persistGlueTable(glueTable, properties);
+ commitStatus = CommitStatus.SUCCESS;
+
Review comment:
nit: extra line to remove
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
##########
@@ -113,29 +112,28 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
checkMetadataLocation(glueTable, base);
Map<String, String> properties = prepareProperties(glueTable,
newMetadataLocation);
Review comment:
nit: extra line to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
