aokolnychyi commented on a change in pull request #2403: URL: https://github.com/apache/iceberg/pull/2403#discussion_r606746251
########## File path: core/src/main/java/org/apache/iceberg/SerializedTable.java ########## @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.io.Serializable; +import java.util.List; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.encryption.EncryptionManager; +import org.apache.iceberg.hadoop.HadoopFileIO; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.io.LocationProvider; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.SerializableMap; + +/** + * A read-only serializable table implementation that can be sent to other nodes. + * <p> + * While this class captures the metadata file location that can be used to load the full table + * metadata, it also serializes directly things like properties, schema, spec, sort order + * to avoid reading the metadata file from other nodes to access frequently needed metadata. + * <p> + * This implementation assumes the passed instances of {@link FileIO}, {@link EncryptionManager}, + * {@link LocationProvider} are serializable. If you are serializing the table using a custom + * serialization framework like Kryo, those instances of {@link FileIO}, {@link EncryptionManager}, + * {@link LocationProvider} must be supported by that particular serialization framework. + * <p> + * <em>Note:</em> loading the full metadata from a large number of nodes can overwhelm the storage. + */ +public class SerializedTable implements Table, Serializable { Review comment: Changed. Resolving this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
