aokolnychyi commented on issue #2382: URL: https://github.com/apache/iceberg/issues/2382#issuecomment-814485296
I took a look as well. The only place we interact with antlr4 from Spark is in `IcebergSparkSqlExtensionsParser#parse`. Our `IcebergSqlExtensionsPostProcessor` is actually a copy of `PostProcessor` in Spark. We thought that is sufficient but it looks like not if we are shading. If I am correct and that's the only place we interact with antlr4 from Spark, the number of classes we should copy should be limited. I guess `UpperCaseCharStream`, `ParseErrorListener`, `ParseException`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
