pvary commented on a change in pull request #2129:
URL: https://github.com/apache/iceberg/pull/2129#discussion_r608438452
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -116,7 +119,13 @@ public void configureJobConf(TableDesc tableDesc, JobConf
jobConf) {
Preconditions.checkArgument(!tableDesc.getTableName().contains(TABLE_NAME_SEPARATOR),
"Can not handle table " + tableDesc.getTableName() + ". Its name
contains '" + TABLE_NAME_SEPARATOR + "'");
String tables = jobConf.get(InputFormatConfig.OUTPUT_TABLES);
- tables = tables == null ? tableDesc.getTableName() : tables +
TABLE_NAME_SEPARATOR + tableDesc.getTableName();
+ String catalogName =
tableDesc.getProperties().getProperty(InputFormatConfig.CATALOG_NAME);
Review comment:
Wouldn't it be better to handle this as the serialized tables, like use
a `prefix`.`tableName`=`value`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
