wypoon commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r608852390
##########
File path: api/src/main/java/org/apache/iceberg/Snapshot.java
##########
@@ -126,4 +126,13 @@
* @return the location of the manifest list for this Snapshot
*/
String manifestListLocation();
+
+ /**
+ * Return the id of the schema used when this snapshot was created, or null
if this information is not available.
+ *
+ * @return schema id associated with this snapshot
+ */
+ default Integer schemaId() {
+ return null;
Review comment:
Yes, schemaId() returns null in the case where the snapshot was written
before this change. Note though, that even after this change, new metadata can
have snapshots without schema id (so schemaId() for those snapshots will return
null), if it is metadata for a table existing before this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
