marton-bod commented on issue #2440: URL: https://github.com/apache/iceberg/issues/2440#issuecomment-815593293
Thanks @duybd81 for flagging this! I think capitalization of the default value should solve this. I also think it would be logical to capitalize it given that it's transformed into a `FileFormat` in almost all cases and therefore has to be capitalized throughout most of the codebase anyway prior to passing it in. I've run the whole test suite with the change and the only test that failed was `org.apache.iceberg.actions.TestCreateActions#testSparkTableReservedProperties`, due to the `format` table prop changing from `iceberg/parquet` to `iceberg/PARQUET`. @aokolnychyi @RussellSpitzer Do you see any potential problems with changing the `format` spark table prop as above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
