jackye1995 commented on pull request #2354:
URL: https://github.com/apache/iceberg/pull/2354#issuecomment-816373542
Thanks for the comment Ryan, I agree that this can be simplified into a part
of the schema itself, something like:
```
{
"type": "struct",
"schema-id": 0,
"row-identifiers": [
1
],
"fields": [
{
"id": 1,
"name": "x",
"required": true,
"type": "long"
}
]
}
```
Originally we were trying to add this as a component of table metadata
because of (1) benefit of versioning, (2) possibility to extend each
row-identifying field for more potential use cases. Since we all agree that (2)
is not likely, and we can also get versioning by adding it into schema, I think
this is a good approach to go.
I will update this PR tomorrow, @openinx meanwhile please let me know if you
have any concern with the new approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
