RussellSpitzer commented on a change in pull request #2437:
URL: https://github.com/apache/iceberg/pull/2437#discussion_r610897117
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/actions/BaseTableMigrationSparkAction.java
##########
@@ -99,20 +93,17 @@
this.sourceTableLocation =
CatalogUtils.URIToString(sourceCatalogTable.storage().locationUri().get());
}
- @Override
- public CreateAction withProperties(Map<String, String> properties) {
- this.additionalProperties.putAll(properties);
- return this;
+ protected void setDestCatalogAndIdent(CatalogPlugin catalog, Identifier
ident) {
Review comment:
I think this was needed before since Snapshot and Migrate descended from
CreateTable Actions, now I don't think you need dest catalog at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
