RussellSpitzer commented on a change in pull request #2460:
URL: https://github.com/apache/iceberg/pull/2460#discussion_r612563395
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -78,7 +78,7 @@ public StructType outputType() {
@Override
public InternalRow[] call(InternalRow args) {
Identifier tableIdent = toIdentifier(args.getString(0),
PARAMETERS[0].name());
- Long olderThanMillis = args.isNullAt(1) ? null :
DateTimeUtils.toMillis(args.getLong(1));
+ Long olderThanMillis = args.isNullAt(1) ? null :
DateTimeUtils.microsToMillis(args.getLong(1));
Review comment:
This could be copied into iceberg code to avoid the spark internal dep?
We could use a version check to adjust the method used if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
