RussellSpitzer commented on a change in pull request #2428:
URL: https://github.com/apache/iceberg/pull/2428#discussion_r612588395



##########
File path: build.gradle
##########
@@ -1021,6 +1029,18 @@ project(':iceberg-spark3-runtime') {
     compile(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
     }
+
+    integrationImplementation 'org.apache.spark:spark-hive_2.12'
+    integrationImplementation 'junit:junit'
+    integrationImplementation 'org.slf4j:slf4j-simple'
+    integrationImplementation project(path: ':iceberg-api', configuration: 
'testArtifacts')
+    integrationImplementation project(path: ':iceberg-hive-metastore', 
configuration: 'testArtifacts')
+    integrationImplementation project(path: ':iceberg-spark', configuration: 
'testArtifacts')
+    integrationImplementation project(path: ':iceberg-spark3', configuration: 
'testArtifacts')
+    integrationImplementation project(path: ':iceberg-spark3-extensions', 
configuration: 'testArtifacts')
+    // Not allowed on our classpath, only the runtime jar is allowed
+    integrationCompileOnly project(':iceberg-spark3-extensions')

Review comment:
       Only spark-hive, the shadow jar output, and test classes are allowed on 
our runtime path




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to