jackye1995 commented on a change in pull request #2465:
URL: https://github.com/apache/iceberg/pull/2465#discussion_r612872453
##########
File path: core/src/main/java/org/apache/iceberg/util/JsonUtil.java
##########
@@ -116,19 +122,42 @@ public static String getStringOrNull(String property,
JsonNode node) {
}
public static List<String> getStringList(String property, JsonNode node) {
- Preconditions.checkArgument(node.has(property), "Cannot parse missing list
%s", property);
+ ImmutableList.Builder<String> builder = ImmutableList.builder();
+ return getCollection(property, node, builder::build, builder::add,
JsonNode::asText,
+ e -> Preconditions.checkArgument(e.isTextual(), "Cannot parse string
from non-text value: %s", e),
+ false);
+ }
+
+ public static Set<Integer> getIntegerSetOrNull(String property, JsonNode
node) {
+ ImmutableSet.Builder<Integer> builder = ImmutableSet.builder();
+ return getCollection(property, node, builder::build, builder::add,
JsonNode::asInt,
+ e -> Preconditions.checkArgument(e.isInt(), "Cannot parse string from
non-integer value: %s", e),
+ true);
+ }
+
+ private static <C extends Collection<T>, T> C getCollection(
+ String property, JsonNode node,
+ Supplier<C> builder, Consumer<T> appender,
+ Function<JsonNode, T> getter, Consumer<JsonNode> validator,
Review comment:
thanks for the suggestion, please see if the new approach looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
