rdblue commented on a change in pull request #2454:
URL: https://github.com/apache/iceberg/pull/2454#discussion_r615323046
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -292,6 +292,12 @@ public Transform hour(String sourceName, int sourceId) {
return Expressions.hours(sourceName);
}
+ @Override
+ public Transform alwaysNull(int fieldId, String sourceName, int
sourceId) {
+ // do nothing for alwaysNull, it doesn't need to be converted to a
transform
+ return null;
Review comment:
Instead of returning null here and discarding nulls automatically, I
think this should return null (or some other signaling value) and fix the part
that consumes the output of the visitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
