huadongliu commented on pull request #2303: URL: https://github.com/apache/iceberg/pull/2303#issuecomment-822819955
Thanks for PR. I was excited to try it out. Before the rewriteDataFiles action in my test, the last snapshot has three manifest files after two table writes and one row-level deletion. After the rewriteDataFiles action, the latest snapshot has four manifest files. The first three basically change manifest entries in the previous manifest files from ADDED to DELETED. The last manifest file points to newly created partition data files. Do the DELETED manifest entries need to be kept in the current snapshot (i.e. manifest files 1, 2 and 3)? After expireSnapshots, those data files are orphaned anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
