RussellSpitzer commented on a change in pull request #2495:
URL: https://github.com/apache/iceberg/pull/2495#discussion_r616212799
##########
File path: core/src/main/java/org/apache/iceberg/util/ManifestFileUtil.java
##########
@@ -59,16 +59,16 @@ boolean canContain(Object value) {
return containsNull;
}
- if (NaNUtil.isNaN(value)) {
- return containsNaN;
- }
-
// if lower bound is null, then there are no non-null values
if (lowerBound == null) {
// the value is non-null, so it cannot match
return false;
Review comment:
Ok I think i understand the issue here,
Previously we would report "null" for the lowerBound when we meant "NaN"
because we weren't recording NaNs, this means if we see a missing lowerBound we
either could have a mix of NaN and Null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
