jackye1995 commented on a change in pull request #2465:
URL: https://github.com/apache/iceberg/pull/2465#discussion_r616245321
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -193,6 +204,11 @@ public UpdateSchema renameColumn(String name, String
newName) {
updates.put(fieldId, Types.NestedField.of(fieldId, field.isOptional(),
newName, field.type(), field.doc()));
}
+ if (identifierFieldNames.contains(name)) {
Review comment:
Yeah, I was expecting the lines above to catch this, but surprisingly it
did not do this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
