marton-bod commented on pull request #2494:
URL: https://github.com/apache/iceberg/pull/2494#issuecomment-823075017


   My impression is that `PartitionUtil` is supposed to define operations on 
Iceberg partitions, whereas here we are dealing with listing Hive partitions so 
it might not be a good idea to mix the two. I'd prefer keeping this 
migration-related logic in this separate `TableMigrationUtil` class, especially 
if more methods will be added to it as migration efforts pick up pace.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to