jackye1995 commented on a change in pull request #2510:
URL: https://github.com/apache/iceberg/pull/2510#discussion_r620906690
##########
File path: core/src/main/java/org/apache/iceberg/AllManifestsTable.java
##########
@@ -53,8 +53,9 @@
Types.NestedField.required(11, "contains_nan",
Types.BooleanType.get()),
Types.NestedField.optional(12, "lower_bound",
Types.StringType.get()),
Types.NestedField.optional(13, "upper_bound", Types.StringType.get())
- )))
- );
+ ))),
+ Types.NestedField.optional(14, "content", Types.StringType.get())
+ );
Review comment:
nit: should not change space for unmodified lines.
##########
File path: core/src/main/java/org/apache/iceberg/ManifestsTable.java
##########
@@ -41,8 +41,9 @@
Types.NestedField.required(11, "contains_nan",
Types.BooleanType.get()),
Types.NestedField.optional(12, "lower_bound",
Types.StringType.get()),
Types.NestedField.optional(13, "upper_bound", Types.StringType.get())
- )))
- );
+ ))),
+ Types.NestedField.required(14, "content", Types.StringType.get())
+ );
Review comment:
nit: should not change space for unmodified lines.
##########
File path: core/src/main/java/org/apache/iceberg/ManifestsTable.java
##########
@@ -94,8 +95,9 @@ protected DataTask task(TableScan scan) {
manifest.addedFilesCount(),
manifest.existingFilesCount(),
manifest.deletedFilesCount(),
- partitionSummariesToRows(spec, manifest.partitions())
- );
+ partitionSummariesToRows(spec, manifest.partitions()),
+ manifest.content().name()
+ );
Review comment:
nit: should not change space for unmodified lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
