edgarRd commented on pull request #2539:
URL: https://github.com/apache/iceberg/pull/2539#issuecomment-828675842
> I would suggest that we should continue to keep constructor package
protected, and expose a public static method like
>
> ```java
> S3InputFile.fromLocation(String location, S3Client client, AwsProperties
awsProperties) {
> ...
> }
> ```
>
> So that the method signatures between `S3InputFile` and `HadoopInputFile`
are consistent. The same applies for `S3OutputFile` versus `HadoopOutputFile`.
Yeah, I thought about this - creating the static methods instead - but
wanted to minimize the changes made. I do agree as well that it would be better
to have consistency across method signatures on S3 vs Hadoop on Input/Output
files.
Thanks for the input, I'll make the changes accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
