jackye1995 edited a comment on pull request #2544: URL: https://github.com/apache/iceberg/pull/2544#issuecomment-829573091
@pvary @marton-bod @lcspinter thanks for the review, I updated based on the comments. For `iceberg.mr.catalog`, I know it can still be used to indicate a default catalog type to be `hive` or `no catalog`, but I think it's probably better to not mention it at all in the documentation, and I also marked it as deprecated in javadoc. Please let me know if this approach sounds good. For the Hadoop catalog table case, I have combined it with the custom catalog table case in `CREATE EXTERNAL TABLE`, by using the hadoop example for custom type, so that people use the same way to create those external tables. Hopefully this is clearer and have less confusion when reading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
