rdblue commented on a change in pull request #2512:
URL: https://github.com/apache/iceberg/pull/2512#discussion_r624787755
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala
##########
@@ -54,8 +66,13 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface) extends ParserI
/**
* Parse a string to a raw DataType without CHAR/VARCHAR replacement.
*/
- override def parseRawDataType(sqlText: String): DataType = {
- delegate.parseRawDataType(sqlText)
+ def parseRawDataType(sqlText: String): DataType = {
Review comment:
I don't think that Iceberg actually uses this method anywhere, so I
would opt for a simpler approach: either throw `UnsupportedOperationException`
or return `parseDataType(sqlText)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
