gszadovszky commented on a change in pull request #2551:
URL: https://github.com/apache/iceberg/pull/2551#discussion_r625148745
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -406,6 +406,8 @@ public Boolean or(Boolean leftResult, Boolean rightResult) {
for (int i = 0; i <= dict.getMaxId(); i++) {
switch (col.getPrimitiveType().getPrimitiveTypeName()) {
+ case FIXED_LEN_BYTE_ARRAY: dictSet.add((T)
conversion.apply(dict.decodeToBinary(i)));
+ break;
Review comment:
I wanted to write the following but Checkstyle failed on it because of
indention. I guess, it is/was a [Checkstyle
bug](https://github.com/checkstyle/checkstyle/issues/341). I don't have
experience on gradle so I am not sure how to fix this in Iceberg configuration.
Probably, we need to upgrade Checkstyle somehow.
Anyway, both the current and this other one is correct but I would prefer
the latter.
```suggestion
case FIXED_LEN_BYTE_ARRAY: // Same as BINARY
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
