RussellSpitzer commented on a change in pull request #2501:
URL: https://github.com/apache/iceberg/pull/2501#discussion_r627073911
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -19,92 +19,120 @@
package org.apache.iceberg.actions;
-import org.apache.iceberg.DataFile;
+import java.util.Map;
+import org.apache.iceberg.StructLike;
import org.apache.iceberg.expressions.Expression;
/**
- * An action that rewrites data files.
+ * An action for rewriting datafiles according to a Rewrite Strategy.
Generally used for
Review comment:
Corrected, RewriteStrategy is the class name though so I switched to a
link. Only issue is as long as RewriteStrategy is package private the link just
shows up as RewriteStrategy. This is actually an issue with us making that
interface package private since an implementation in spark would have to be in
a different package than the Spark action implementations which are all in
`o.a.iceberg.spark.actions` and not `o.a.iceberg.actions` ... may have to think
about this later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
