aokolnychyi commented on a change in pull request #2503:
URL: https://github.com/apache/iceberg/pull/2503#discussion_r627836067



##########
File path: 
spark/src/main/java/org/apache/iceberg/spark/actions/BaseRemoveOrphanFilesSparkAction.java
##########
@@ -140,10 +142,19 @@ public BaseRemoveOrphanFilesSparkAction 
deleteWith(Consumer<String> newDeleteFun
 
   @Override
   public RemoveOrphanFiles.Result execute() {
-    JobGroupInfo info = newJobGroupInfo("REMOVE-ORPHAN-FILES", 
"REMOVE-ORPHAN-FILES");
+    JobGroupInfo info = newJobGroupInfo("REMOVE-ORPHAN-FILES", 
getDescription());
     return withJobGroupInfo(info, this::doExecute);
   }
 
+  private String getDescription() {
+    List<String> msg = new ArrayList<>();
+    msg.add("older_than=" + olderThanTimestamp);
+    if (location != null) {
+      msg.add("location=" + location);
+    }
+    return String.format("Removing orphan files(%s) from %s", 
StringUtils.join(msg, ","), table.name());

Review comment:
       Oh, yeah, we handle it by passing an empty delete function. Never mind.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to