jackye1995 commented on a change in pull request #2410:
URL: https://github.com/apache/iceberg/pull/2410#discussion_r628989589
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
##########
@@ -61,7 +65,22 @@ public static Schema convert(TableSchema schema) {
RowType root = (RowType) schemaType;
Type converted = root.accept(new FlinkTypeToType(root));
- return new Schema(converted.asStructType().fields());
+ Schema iSchema = new Schema(converted.asStructType().fields());
+ return freshIdentifierFieldIds(iSchema, schema);
+ }
+
+ private static Schema freshIdentifierFieldIds(Schema iSchema, TableSchema
schema) {
Review comment:
instead of having this method, if we expose a
`TypeUtil.freshIdentifierFieldIds(Schema iSchema, Schema base)`, can we do a
conversion of Flink to Iceberg schema and then call that method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
