RussellSpitzer commented on a change in pull request #2574:
URL: https://github.com/apache/iceberg/pull/2574#discussion_r629496499
##########
File path: deploy.gradle
##########
@@ -113,8 +113,8 @@ subprojects {
// upload to the releases repository using ./gradlew -Prelease publish
def apacheSnapshotsRepoUrl =
'https://repository.apache.org/content/repositories/snapshots'
def apacheReleasesRepoUrl =
'https://repository.apache.org/service/local/staging/deploy/maven2'
- def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ?
project.property('mavenSnapshotsRepo') : "$apacheSnapshotsRepoUrl"
- def releasesRepoUrl = project.hasProperty('mavenReleasesRepo') ?
project.property('mavenReleasesRepo') : "$apacheReleasesRepoUrl"
+ def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ?
"$mavenSnapshotsRepo" : "$apacheSnapshotsRepoUrl"
Review comment:
I'm still lost a bit I think
```groovy
def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ?
"$mavenSnapshotsRepo" : "$apacheSnapshotsRepoUrl"
```
should be
```groovy
def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ?
project.property("mavenSnapshotsRepo") : "$apacheSnapshotsRepoUrl"
```
When I do a quick test
```groovy
print(project.hasProperty("mavenSnapshotsRepo"))
print(project.property("mavenSnapshotsRepo"))
print($mavenSnapshotsRepo)
```
and
```bash
g -PmavenSnapshotsRepo=one
```
Then I get mavenSnapshotsRepo undefined but the first two work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
