RussellSpitzer commented on a change in pull request #2564: URL: https://github.com/apache/iceberg/pull/2564#discussion_r629671612
########## File path: core/src/main/java/org/apache/iceberg/MetadataLocationUtils.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.io.FileIO; + +public class MetadataLocationUtils { + + private MetadataLocationUtils() { + } + + /** + * Returns all Metadata file paths which may not be in the current metadata. Specifically + * this includes "version-hint" files as well as entries in metadata.previousFiles. + * @param ops TableOperations of the table to get paths from + * @param isRecursive when true, recursively retrieves all the metadata.json files using metadata.previousFiles + * <p>when false, gets the all the metadata.json files pointed to by the only current metadata.json + * @return a list of paths to metadata files + */ + public static List<String> miscMetadataFiles(TableOperations ops, boolean isRecursive) { + Set<String> miscMetadataLocation = new HashSet<>(); + miscMetadataLocation.add(ops.metadataFileLocation("version-hint.text")); + String location = ops.current().metadataFileLocation(); + miscMetadataLocation.add(location); + miscMetadataFiles(location, miscMetadataLocation, ops.io(), isRecursive); + return new ArrayList<>(miscMetadataLocation); + } + + private static void miscMetadataFiles(String metadataFileLocation, Set<String> metaFiles, + FileIO io, boolean isRecursive) { + if (metadataFileLocation == null) { + return; + } + TableMetadata metadata = TableMetadataParser.read(io, metadataFileLocation); + List<TableMetadata.MetadataLogEntry> metadataLogEntries = metadata.previousFiles(); + List<String> previousMetadataFiles = + metadataLogEntries.stream().map(TableMetadata.MetadataLogEntry::file) + .collect(Collectors.toList()); + if (previousMetadataFiles.size() > 0) { + metaFiles.addAll(previousMetadataFiles); + if (isRecursive) { + for (String fileName : previousMetadataFiles) { + // Find the first existent metadata json file and recurse + if (io.newInputFile(fileName).exists()) { + miscMetadataFiles(fileName, metaFiles, io, isRecursive); + break; Review comment: I'd skip the break too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
