aokolnychyi commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r630502787
##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -46,6 +47,35 @@ public static MetricsConfig getDefault() {
return spec;
}
+ public static Map<String, String> updateProperties(Map<String, String>
props, List<String> deletes,
Review comment:
This class as well as `SchemaUpdate` (where the new method is used) are
in `org.apache.iceberg` package. I don't think users are supposed to interact
with this logic, so I'd make the method package-private like we do in other
places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
