flyrain commented on a change in pull request #2564:
URL: https://github.com/apache/iceberg/pull/2564#discussion_r631289564
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java
##########
@@ -109,40 +110,6 @@ protected JobGroupInfo newJobGroupInfo(String groupId,
String desc) {
return new JobGroupInfo(groupId + "-" + JOB_COUNTER.incrementAndGet(),
desc, false);
}
- /**
- * Returns all the path locations of all Manifest Lists for a given list of
snapshots
- * @param snapshots snapshots
- * @return the paths of the Manifest Lists
- */
- private List<String> getManifestListPaths(Iterable<Snapshot> snapshots) {
Review comment:
Can we remove the same method in class `BaseAction`? This applies to
`getOtherMetadataFilePaths` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
