stevenzwu commented on a change in pull request #2410:
URL: https://github.com/apache/iceberg/pull/2410#discussion_r631576870
##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -209,9 +209,18 @@ public static StructLikeSet expectedRowSet(Table table,
Record... records) {
}
public static StructLikeSet actualRowSet(Table table, String... columns)
throws IOException {
+ table.refresh();
Review comment:
got it. I just found it a little weird that we have to call
`table.refresh` twice in this case. I think your intention is to support
`actualRowSet` for either latest snapshot or specific snapshotId. maybe define
the overloaded method as below. Then this method can just pass in null for the
`snapshotId`
```
actualRowSet(Table table, @Nullable Long snapshotId, String... columns)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
