zhangjun0x01 commented on a change in pull request #2566:
URL: https://github.com/apache/iceberg/pull/2566#discussion_r631586450
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java
##########
@@ -91,11 +105,85 @@ public void configure(Configuration parameters) {
@Override
public void open(FlinkInputSplit split) {
+ boolean enableVectorizedRead =
readableConfig.get(FlinkTableOptions.ENABLE_VECTORIZED_READ);
+
+ if (enableVectorizedRead) {
+ if (useOrcVectorizedRead(split.getTask())) {
Review comment:
> We also don't need the separate method of `setDefaultIterator`
At first, I wanted to use non-vectorized read when judge failed of
vectorized read, so I extracted this method, but later I think it inappropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
