stevenzwu commented on a change in pull request #2105:
URL: https://github.com/apache/iceberg/pull/2105#discussion_r632167819
##########
File path: build.gradle
##########
@@ -318,14 +318,24 @@ project(':iceberg-flink') {
compileOnly "org.apache.flink:flink-table-api-java-bridge_2.12"
compileOnly "org.apache.flink:flink-table-planner-blink_2.12"
compileOnly "org.apache.flink:flink-table-planner_2.12"
+ compileOnly "org.apache.flink:flink-parquet_2.12"
compileOnly "org.apache.hadoop:hadoop-hdfs"
compileOnly "org.apache.hadoop:hadoop-common"
compileOnly("org.apache.hadoop:hadoop-minicluster") {
exclude group: 'org.apache.avro', module: 'avro'
}
+ // flink-dist doesn't include these two modules (FLINK-20098).
+ // Hence we should add them as compile deps.
+ // This doesn't affect iceberg-flink-runtime shadow jar,
+ // since it excludes all flink jars.
+ compile "org.apache.flink:flink-connector-base"
+ compile "org.apache.flink:flink-connector-files"
Review comment:
originally it was `compileOnly`. I changed it after the review
comments/discussions:
https://github.com/apache/iceberg/pull/2105#discussion_r571299927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
