RussellSpitzer commented on a change in pull request #2600:
URL: https://github.com/apache/iceberg/pull/2600#discussion_r633899916
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -45,20 +44,12 @@
abstract class BinPackStrategy implements RewriteStrategy {
/**
- * Minimum number of files that need to be in a file group to be considered
- * for rewriting. This is considered in conjunction with {@link
MIN_OUTPUT_FILES}, both
- * conditions must pass to consider a group of files to be rewritten.
+ * The minimum number of files that need to be in a file group for it to be
considered for
+ * compaction if the total size of that group is not the target size. This
can also be thought of as
+ * the maximum number of non-target-size files that should remain in a file
group (parititon) after rewriting.
Review comment:
I couldn't say why but I think it should be "could" ... replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
