rdblue commented on a change in pull request #2577:
URL: https://github.com/apache/iceberg/pull/2577#discussion_r635662268
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -90,6 +90,12 @@ private TableProperties() {
public static final String ORC_VECTORIZATION_ENABLED =
"read.orc.vectorization.enabled";
public static final boolean ORC_VECTORIZATION_ENABLED_DEFAULT = false;
+ public static final String LOCALITY_ENABLED = "read.locality.enabled";
+ public static final String LOCALITY_ENABLED_DEFAULT = null;
+
+ public static final String LOCALITY_TASK_INITIALIZE_THREADS =
"read.locality.task.initialize.threads";
+ public static final int LOCALITY_TASK_INITIALIZE_THREADS_DEFAULT = 1;
Review comment:
If this PR is adding the ability to disable locality, I think it should
remain focused on that task and should not include a separate feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
